[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

It seems to me part of the goal of Alex's efforts is to make it possible for a given lldb to have or not have support for any particular type system.  In some future day they might even be live pluggable, so that which ones get loaded would be a user choice.  In that future, it is never an error to not have a given type system.  And even if lldb has builtin code to support a given type system, I may not want to pay the cost to construct it.  If I'm debugging ObjC code in a program that also supports swift, I might want to tell lldb not to bother with swift types.

If that seems reasonable, then TypeSystems are really optional, and you should always be prepared for one not to exist.  IIUC that's better expressed by Optional than Expected.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65122/new/

https://reviews.llvm.org/D65122