[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 25 14:47:53 PDT 2019


jankratochvil marked an inline comment as done.
jankratochvil added a comment.

In D65271#1600829 <https://reviews.llvm.org/D65271#1600829>, @labath wrote:

> Why not unify now? It shouldn't be too hard to at least unify all the instances in dotest python code to a single place. That would already cut the number of places that need to be kept synced in half...


Done; but I do not like much that `from lldbsuite.test.lldbtest import Base` in `vscode.py` but then other choices (passing `Base.setUpCommands()` from callers) looks even more messy to me.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65271/new/

https://reviews.llvm.org/D65271





More information about the lldb-commits mailing list