[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:203-204
+  if (NOT CMAKE_CROSSCOMPILING)
+    # Manually split PYTHON_VERSION_STRING because find_python_libs_windows
+    # doesn't set PYTHON_VERSION_MAJOR or PYTHON_VERSION_MINOR.
+    string(REPLACE "." ";" python_version_list ${PYTHON_VERSION_STRING})
----------------
labath wrote:
> If this is the only reason, then maybe we could fix find_python_libs_windows to set the relevant variables instead (?)
FindPythonLibs only sets `PYTHONLIBS_VERSION_STRING`, so we'd still have that to parse the major and minor version of that manually. It was a coin flip between keeping the parsing together and updating `find_python_libs_windows`. I'm happy to do either. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65230/new/

https://reviews.llvm.org/D65230