[Lldb-commits] [lldb] r366803 - ProcessMachCore: Fix a -Wmisleading-indentation warning

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 23 05:53:45 PDT 2019


Author: labath
Date: Tue Jul 23 05:53:45 2019
New Revision: 366803

URL: http://llvm.org/viewvc/llvm-project?rev=366803&view=rev
Log:
ProcessMachCore: Fix a -Wmisleading-indentation warning

Modified:
    lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp

Modified: lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp?rev=366803&r1=366802&r2=366803&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp (original)
+++ lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp Tue Jul 23 05:53:45 2019
@@ -338,44 +338,43 @@ Status ProcessMachCore::DoLoadCore() {
                       "from LC_IDENT/LC_NOTE 'kern ver str' string: '%s'", 
                       corefile_identifier.c_str());
 
-          // We're only given a UUID here, not a load address.
-          // But there are python scripts in the EFI binary's dSYM which
-          // know how to relocate the binary to the correct load address.
-          // lldb only needs to locate & load the binary + dSYM.
-          ModuleSpec module_spec;
-          module_spec.GetUUID() = uuid;
-          module_spec.GetArchitecture() = GetTarget().GetArchitecture();
-
-          // Lookup UUID locally, before attempting dsymForUUID like action
-          FileSpecList search_paths =
-              Target::GetDefaultDebugFileSearchPaths();
-          module_spec.GetSymbolFileSpec() =
-              Symbols::LocateExecutableSymbolFile(module_spec, search_paths);
-          if (module_spec.GetSymbolFileSpec()) {
-            ModuleSpec executable_module_spec =
-                Symbols::LocateExecutableObjectFile(module_spec);
-            if (FileSystem::Instance().Exists(executable_module_spec.GetFileSpec())) {
-              module_spec.GetFileSpec() =
-                  executable_module_spec.GetFileSpec();
-            }
+        // We're only given a UUID here, not a load address.
+        // But there are python scripts in the EFI binary's dSYM which
+        // know how to relocate the binary to the correct load address.
+        // lldb only needs to locate & load the binary + dSYM.
+        ModuleSpec module_spec;
+        module_spec.GetUUID() = uuid;
+        module_spec.GetArchitecture() = GetTarget().GetArchitecture();
+
+        // Lookup UUID locally, before attempting dsymForUUID like action
+        FileSpecList search_paths = Target::GetDefaultDebugFileSearchPaths();
+        module_spec.GetSymbolFileSpec() =
+            Symbols::LocateExecutableSymbolFile(module_spec, search_paths);
+        if (module_spec.GetSymbolFileSpec()) {
+          ModuleSpec executable_module_spec =
+              Symbols::LocateExecutableObjectFile(module_spec);
+          if (FileSystem::Instance().Exists(
+                  executable_module_spec.GetFileSpec())) {
+            module_spec.GetFileSpec() = executable_module_spec.GetFileSpec();
           }
+        }
 
-          // Force a a dsymForUUID lookup, if that tool is available.
-          if (!module_spec.GetSymbolFileSpec())
-            Symbols::DownloadObjectAndSymbolFile(module_spec, true);
-
-          if (FileSystem::Instance().Exists(module_spec.GetFileSpec())) {
-            ModuleSP module_sp(new Module(module_spec));
-            if (module_sp.get() && module_sp->GetObjectFile()) {
-              // Get the current target executable
-              ModuleSP exe_module_sp(GetTarget().GetExecutableModule());
-
-              // Make sure you don't already have the right module loaded
-              // and they will be uniqued
-              if (exe_module_sp.get() != module_sp.get())
-                GetTarget().SetExecutableModule(module_sp, eLoadDependentsNo);
-            }
+        // Force a a dsymForUUID lookup, if that tool is available.
+        if (!module_spec.GetSymbolFileSpec())
+          Symbols::DownloadObjectAndSymbolFile(module_spec, true);
+
+        if (FileSystem::Instance().Exists(module_spec.GetFileSpec())) {
+          ModuleSP module_sp(new Module(module_spec));
+          if (module_sp.get() && module_sp->GetObjectFile()) {
+            // Get the current target executable
+            ModuleSP exe_module_sp(GetTarget().GetExecutableModule());
+
+            // Make sure you don't already have the right module loaded
+            // and they will be uniqued
+            if (exe_module_sp.get() != module_sp.get())
+              GetTarget().SetExecutableModule(module_sp, eLoadDependentsNo);
           }
+        }
       }
   }
 




More information about the lldb-commits mailing list