[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 23 00:05:38 PDT 2019


labath added a comment.

I think setting -DPYTHON_EXECUTABLE=C:\Users\hwennborg\AppData\Local\Programs\Python\Python36-32\python.exe (or something) should be enough to get cmake to select python3 for the interpreter as well.

As for the version mismatch, the one of the reasons why the mismatched version did not work on unix is because some of our python build scripts assume that lldb will be running the same version of python as they are and derive python site-packages dir based on that. This is bad practice because of cross-compiling, but it may not be an issue on windows because there the site-packages dir does not include the python version (lib/site-packages vs lib/pythonX.Y/site-packages). So it's possible we can skip the version mismatch check on windows.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64881/new/

https://reviews.llvm.org/D64881





More information about the lldb-commits mailing list