[Lldb-commits] [PATCH] D65025: [Symbol] Improve TypeSystemMap mutex safety

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 19 16:04:49 PDT 2019


xiaobai abandoned this revision.
xiaobai added a comment.

Actually from the looks of it, I completely misunderstood what's going on here. It looks like `AddToMap` should only be called by things that hold the mutex, meaning that this change isn't actually necessary. I do think that makes this code kind of frustrating to understand though. Closing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65025/new/

https://reviews.llvm.org/D65025





More information about the lldb-commits mailing list