[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes
Hui Huang via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jul 18 21:10:44 PDT 2019
Hui added inline comments.
Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h:45-49
+ NativeProcessWindows(ProcessLaunchInfo &launch_info, NativeDelegate &delegate,
+ llvm::Error &E);
+ NativeProcessWindows(lldb::pid_t pid, int terminal_fd,
+ NativeDelegate &delegate, llvm::Error &E);
> labath wrote:
> > I guess these shouldn't be public as these object should be constructed through the factory, right?
> This doesn't seem to be addressed.
These constructors contain a call to function template make_unique that is not allowed to access private members of NativeProcessWindows.
Simply do the following could address this concern.
- auto process_up =
- std::make_unique<NativeProcessWindows>(launch_info, native_delegate, E);
+ auto process_up = std::unique_ptr<NativeProcessWindows>(
+ new NativeProcessWindows(launch_info, native_delegate, E));
CHANGES SINCE LAST ACTION
More information about the lldb-commits