[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 17 11:01:38 PDT 2019


xiaobai added a comment.

I think that this is a good change overall to do but the name `LLDB_USE_SYSTEM_DEBUGSERVER` is kind of a confusing to me. The name itself doesn't really convey to me that the system debugserver is going to be used for just testing. Before this change, that flag indicated that the system debugserver was going to be used for everything. Maybe you could change it to something like `LLDB_TEST_WITH_SYSTEM_DEBUGSERVER`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64806/new/

https://reviews.llvm.org/D64806





More information about the lldb-commits mailing list