[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 17 10:33:38 PDT 2019
JDevlieghere added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/main.c:9
> TWeaver wrote:
> > Hi there,
> > this is a little nit picky, and I'm not entirely sure If im right in saying so, but, if this is a C++ file as denoted by the license header, then shouldn't this include by <cstdlib> rather than the c library stdlib.h?
> > thanks for your time
> > Tom
> This is definitely a C file, the header is wrong.
Also, I believe the consensus is that we don't need the header in test files.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits