[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jul 16 02:42:23 PDT 2019
labath added a comment.
Sorry for the delay. The patch looks fine to me. As far as testing goes, there's a "gdb-client" test suite in `test/testcases/functionalities/gdb_remote_client/`, which should allow you to mock gdb-server responses and verify that the right packets are being sent.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:154
I'd add a trailing comma here to avoid changing this line next time we add a setting.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits