[Lldb-commits] [PATCH] D64782: [SWIG] Deprecate SWIG 1.x

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: LLDB.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.

The last swig 1.x release dates from 2009, now 10 years ago. Recently I fixed an issue that prevented us from using swig 4 (rL364974 <https://reviews.llvm.org/rL364974>), which apparently was not backward compatible with swig 1.x (rL365718 <https://reviews.llvm.org/rL365718>). Rather that introducing the workaround for all the properties, I propose to deprecate this (really old) version.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D64782

Files:
  lldb/scripts/CMakeLists.txt


Index: lldb/scripts/CMakeLists.txt
===================================================================
--- lldb/scripts/CMakeLists.txt
+++ lldb/scripts/CMakeLists.txt
@@ -14,6 +14,11 @@
 endif()
 
 find_package(SWIG REQUIRED)
+set(SWIG_MIN_VERSION "2.0.0")
+if (${SWIG_VERSION} VERSION_LESS ${SWIG_MIN_VERSION})
+  message(FATAL_ERROR "LLDB requires swig ${SWIG_MIN_VERSION}, your version is ${SWIG_VERSION}.")
+endif()
+
 add_custom_command(
   OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
   OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64782.210002.patch
Type: text/x-patch
Size: 546 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190716/7d434807/attachment.bin>