[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control
Kamil Rytarowski via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sat Jul 13 02:26:22 PDT 2019
krytarowski added a comment.
In D64647#1584340 <https://reviews.llvm.org/D64647#1584340>, @mgorny wrote:
> In D64647#1583429 <https://reviews.llvm.org/D64647#1583429>, @krytarowski wrote:
> > Something that we do not cover here is that once a tracee reports a signal (like someone poked it with SIGUSR1) and we want to pass it over to the tracee, we will reset siginfo.
> > This scenario should be covered by a test and we should handle it properly..
> > The solution in NetBSD for passing over signals without changing siginfo, is to not calling PT_SET_SIGINFO as the default one will be kept by the kernel. Optionally pick old siginfo with PT_GET_SIGINFO and optionally change destination lwp.
> How is 'properly'? Should we reject resuming with a signal when there's already another signal pending?
We need to pass the same signal (with unchanged siginfo) to the tracee.
The easiest way is to not changing it, however as we can emit a signal over to tracee specifying LWP. we can go for the sequence of PT_GET_SIGINFO, change lwp, PT_SET_SIGINFO, PT_CONTINUE with a signal.
CHANGES SINCE LAST ACTION
More information about the lldb-commits