[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 12 12:58:04 PDT 2019


labath added inline comments.


================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:354
+      if (signal != LLDB_INVALID_SIGNAL_NUMBER && signal != action->signal)
+        return Status("NetBSD does not support passing multiple signals simultaneously");
 
----------------
krytarowski wrote:
> mgorny wrote:
> > labath wrote:
> > > Is this "passing multiple signals simultaneously", or "passing multiple *distinct* signals simultaneously". (E.g,. thread 1 gets a SIGALRM, thread 2 gets SIGIO, etc.).
> > The former. Basically there's one siginfo slot, so you can either put a signal for whole process, or for one LWP.
> Once we emit a single signal to all threads, it's still technically a single signal that hits the process.
Ok, that makes sense. But I don't think that's what the code does right now (IIUC, this line will only fire if the current signal is different that the signal sent to the previous thread).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64647/new/

https://reviews.llvm.org/D64647





More information about the lldb-commits mailing list