[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 12 10:56:48 PDT 2019


labath added a comment.

Shouldn't there be some tests that come along with this patch?



================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp:56
+  ret = NativeProcessNetBSD::PtraceWrapper(PT_SETSTEP, m_process.GetID(),
+                                           nullptr, -GetID());
+  if (ret.Success())
----------------
Is this really meant to be negative?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64647/new/

https://reviews.llvm.org/D64647





More information about the lldb-commits mailing list