[Lldb-commits] [PATCH] D64599: [LanguageRuntime] Move CPPLanguageRuntime into a plugin
Saleem Abdulrasool via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jul 11 14:32:09 PDT 2019
compnerd added inline comments.
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:55
> JDevlieghere wrote:
> > What's the benefit of making this a separate plugin, as compared to making it part of `Plugins/Language/CPlusPlus`?
> I view LanguageRuntimes as distinct from Languages and thus I think they should go into their own plugins. However, I'm not against moving this to `Plugins/Language/CPlusPlus` if you think it would make more sense to do so for another reason (e.g. less plugins overall?)
We do need the abstraction since there are multiple C++ runtimes: c++, stdc++, MSVCPRT, stlport, etc. Each one is slightly different. Furthermore, libstdc++ supported the GNU and Solaris ABIs, libc++ only does itanium, MSVCPRT only does MSVC ABI. So, we need to have some layer to differentiate between the various ABIs and just general C++ language support.
CHANGES SINCE LAST ACTION
More information about the lldb-commits