[Lldb-commits] [PATCH] D64434: [lldb] Quick Fix: IRExecutionUnit check pointer before access it

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 9 15:24:44 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL365567: [lldb] Quick Fix: IRExecutionUnit check pointer before access it (authored by xiaobai, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D64434?vs=208763&id=208828#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64434/new/

https://reviews.llvm.org/D64434

Files:
  lldb/trunk/source/Expression/IRExecutionUnit.cpp


Index: lldb/trunk/source/Expression/IRExecutionUnit.cpp
===================================================================
--- lldb/trunk/source/Expression/IRExecutionUnit.cpp
+++ lldb/trunk/source/Expression/IRExecutionUnit.cpp
@@ -285,9 +285,6 @@
 
   m_execution_engine_up.reset(builder.create(target_machine));
 
-  m_strip_underscore =
-      (m_execution_engine_up->getDataLayout().getGlobalPrefix() == '_');
-
   if (!m_execution_engine_up) {
     error.SetErrorToGenericError();
     error.SetErrorStringWithFormat("Couldn't JIT the function: %s",
@@ -295,6 +292,9 @@
     return;
   }
 
+  m_strip_underscore =
+      (m_execution_engine_up->getDataLayout().getGlobalPrefix() == '_');
+
   class ObjectDumper : public llvm::ObjectCache {
   public:
     void notifyObjectCompiled(const llvm::Module *module,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64434.208828.patch
Type: text/x-patch
Size: 818 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190709/b717dc61/attachment.bin>


More information about the lldb-commits mailing list