[Lldb-commits] [lldb] r365388 - [lldb] Fix two more issues in Windows following rL365226: Change LaunchThread interface to return an expected

Stella Stamenova via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 8 14:17:58 PDT 2019


Author: stella.stamenova
Date: Mon Jul  8 14:17:58 2019
New Revision: 365388

URL: http://llvm.org/viewvc/llvm-project?rev=365388&view=rev
Log:
[lldb] Fix two more issues in Windows following rL365226: Change LaunchThread interface to return an expected

A couple of the function signatures changed and they were not updated in the Windows HostProcess

Modified:
    lldb/trunk/include/lldb/Host/windows/HostProcessWindows.h
    lldb/trunk/source/Host/windows/HostProcessWindows.cpp

Modified: lldb/trunk/include/lldb/Host/windows/HostProcessWindows.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/windows/HostProcessWindows.h?rev=365388&r1=365387&r2=365388&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Host/windows/HostProcessWindows.h (original)
+++ lldb/trunk/include/lldb/Host/windows/HostProcessWindows.h Mon Jul  8 14:17:58 2019
@@ -30,8 +30,9 @@ public:
   lldb::pid_t GetProcessId() const override;
   bool IsRunning() const override;
 
-  HostThread StartMonitoring(const Host::MonitorChildProcessCallback &callback,
-                             bool monitor_signals) override;
+  virtual llvm::Expected<HostThread>
+  StartMonitoring(const Host::MonitorChildProcessCallback &callback,
+                  bool monitor_signals) override;
 
 private:
   static lldb::thread_result_t MonitorThread(void *thread_arg);

Modified: lldb/trunk/source/Host/windows/HostProcessWindows.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/windows/HostProcessWindows.cpp?rev=365388&r1=365387&r2=365388&view=diff
==============================================================================
--- lldb/trunk/source/Host/windows/HostProcessWindows.cpp (original)
+++ lldb/trunk/source/Host/windows/HostProcessWindows.cpp Mon Jul  8 14:17:58 2019
@@ -94,7 +94,7 @@ llvm::Expected<HostThread> HostProcessWi
                         &info->process_handle, 0, FALSE, DUPLICATE_SAME_ACCESS))
     result = ThreadLauncher::LaunchThread("ChildProcessMonitor",
                                           HostProcessWindows::MonitorThread,
-                                          info, nullptr);
+                                          info);
   return result;
 }
 




More information about the lldb-commits mailing list