[Lldb-commits] [PATCH] D64365: [lldb] Let table gen create command option initializers.

Mon Jul 8 13:57:42 PDT 2019

labath added a comment.

I like this, though I am not really familiar with details of implementing a tablegen backend. This should make it easier to migrate to the llvmOption library, once we arrive to that point.

================
Comment at: lldb/utils/TableGen/LLDBOptionDefEmitter.cpp:26
+/// Map of command names to their associated records.
+typedef std::map<std::string, std::vector<Record *>> RecordsByCommand;
+
----------------
llvm::StringMap

================
Comment at: lldb/utils/TableGen/LLDBTableGen.cpp:31
+
+namespace {
+cl::opt<ActionType>
----------------
use static instead of anonymous namespace.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64365/new/

https://reviews.llvm.org/D64365