[Lldb-commits] [lldb] r365246 - lldb_assert: abort when assertions are enabled.
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Fri Jul 5 14:22:54 PDT 2019
Date: Fri Jul 5 14:22:54 2019
New Revision: 365246
lldb_assert: abort when assertions are enabled.
We had a long discussion in D59911 about lldb_assert and what it means.
The result was the assert manifesto on lldb.llvm.org.
> LLDB provides lldb_assert() as a soft alternative to cover the middle
> ground of situations that indicate a recoverable bug in LLDB. In a
> Debug configuration lldb_assert() behaves like assert(). In a Release
> configuration it will print a warning and encourage the user to file a
> bug report, similar to LLVM’s crash handler, and then return
However, currently lldb_assert doesn't behave they way it's being
described there: it doesn't abort in a debug/assert build. This patch
fixes that by adding a call to assert() in lldb_assert().
Differential revision: https://reviews.llvm.org/D64267#1571962
--- lldb/trunk/source/Utility/LLDBAssert.cpp (original)
+++ lldb/trunk/source/Utility/LLDBAssert.cpp Fri Jul 5 14:22:54 2019
@@ -21,6 +21,12 @@ void lldb_private::lldb_assert(bool expr
+ // In a Debug configuration lldb_assert() behaves like assert().
+ assert(false && "lldb_assert failed");
+ // In a Release configuration it will print a warning and encourage the user
+ // to file a bug report, similar to LLVMâs crash handler, and then return
+ // execution.
errs() << format("Assertion failed: (%s), function %s, file %s, line %u\n",
expr_text, func, file, line);
errs() << "backtrace leading to the failure:\n";
More information about the lldb-commits