[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked 5 inline comments as done.
jankratochvil added inline comments.


================
Comment at: lldb/lit/SymbolFile/sizeless-symbol.test:10
+image dump symtab
+# CHECK:Index   UserID DSX Type            File Address/Value Load Address       Size               Flags      Name
+# CHECK-NEXT:------- ------ --- --------------- ------------------ ------------------ ------------------ ---------- ----------------------------------
----------------
labath wrote:
> Nit: Please line up this table by inserting a couple of spaces between ":" and "Index".
Great, I did not expect it will still match with the added whitespaces.


================
Comment at: lldb/source/Symbol/Symtab.cpp:904
+        // same address. So do not set size of a non-last zero-sized symbol.
+        if (i == num_entries - 1 || m_file_addr_to_index.GetMutableEntryAtIndex(i + 1)->GetRangeBase() != curr_base_addr) {
           const RangeVector<addr_t, addr_t>::Entry *containing_section =
----------------
labath wrote:
> Please clang-format this.
Sorry I forgot to run the clang-format.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63540/new/

https://reviews.llvm.org/D63540