[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 28 10:52:52 PDT 2019
clayborg added a comment.
In D63240#1562527 <https://reviews.llvm.org/D63240#1562527>, @jingham wrote:
> This looks good to me. I wonder if the SymbolContextScope -> Language calculation that you do in IsRuntimeSupportValue should really be done in SymbolContextScope? If that's going to be the policy for going from SymbolContextScope, maybe centralize it there?
I agree, centralize this in SymbolContextScope and this should be good to go. Thanks for sticking with this Alex.
CHANGES SINCE LAST ACTION
More information about the lldb-commits