[Lldb-commits] [PATCH] D63914: Make the expression parser work for missing weak symbols
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 27 18:07:33 PDT 2019
jingham created this revision.
jingham added reviewers: JDevlieghere, clayborg.
Herald added subscribers: lldb-commits, teemperor, abidh.
Herald added a project: LLDB.
lldb wasn't handling weak symbols, so if you were debugging a binary that used a weak symbol, and the symbol was missing, any references to the symbol would result in a symbol not found error. But it is actually legitimate to refer to missing weak symbols, you just have to test them against NULL first.
This patch does three things:
1. Adds a bit to indicate weakness to Symbol and IsWeak & SetIsWeak accessors
2. Teaches the ObjectFileMachO to detect weak symbols and mark them appropriately
3. Gets the symbol -> address lookup in IRExecutionUnit.cpp to mark missing weak symbols as such.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 20981 bytes
Desc: not available
More information about the lldb-commits