[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added a comment.

> In D63745#1556941 <https://reviews.llvm.org/D63745#1556941>, @labath wrote:
>  This code should go to tools/debugserver/source/CMakeLists.txt

+1

More precisely, this is the condition where you want to do your check:
https://github.com/llvm/llvm-project/blob/287f0403e310/lldb/tools/debugserver/source/CMakeLists.txt#L131

You don't need `if(CMAKE_SYSTEM_NAME MATCHES "Darwin" AND TARGET debugserver)` there.
Use `${LLDB_CODESIGN_IDENTITY_USED}` instead of `lldb_codesign`.
Error message could recommend `-DLLDB_USE_SYSTEM_DEBUGSERVER=ON` and/or `-DLLDB_NO_DEBUGSERVER=ON`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63745/new/

https://reviews.llvm.org/D63745