[Lldb-commits] [PATCH] D63594: [lldb] [Process/NetBSD] Simplify register buffer usage
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 20 04:28:28 PDT 2019
labath added a comment.
How about we go even a bit further? The non-`Do` functions are now so trivial that the `Do` functions could be inlined into them, producing something like `return NativeProcessNetBSD::PtraceWrapper(PT_GETFPREGS, GetProcessPid(), GetFPRBuffer(),m_thread.GetID());`. If you wanted to be really fancy, you could define a function like `ReadRegisterSet(T regset, void *buffer)`, and call make that be `ReadRegisterSet(PT_GETFPREGS, GetFPRBuffer());`
CHANGES SINCE LAST ACTION
More information about the lldb-commits