[Lldb-commits] [PATCH] D63491: DWARF: Use a more compact internal representation in the manual dwarf index

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 18 07:14:32 PDT 2019

clayborg added a comment.

In D63491#1548238 <https://reviews.llvm.org/D63491#1548238>, @labath wrote:

> I made this depend on the DIERef patch instead of the other way around because the cleaner separation between dwo identifiers and compile unit offsets implemented in that patch makes it easier to implement this. It would still be possible to implement it the other way around, but the logic would be more complex, and it would have to be redone anyway once the DIERef patch lands.
> Another possibility would be to just remove the unit_offset field from the DIERef class, and have the manual index keep using DIERefs. Once we introduce the dwo identifier, the unit offset is strictly optional, as the unit is uniquely identified by the other coordinates.

Lets just fix the DIERef class and remove the unit_offset field? No need for yet another minimal DIE reference class.



More information about the lldb-commits mailing list