[Lldb-commits] [PATCH] D63400: DWARF: Provide accessors to DIERef fields

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 17 07:26:10 PDT 2019


clayborg added a comment.

Just questioning if we want to increase the size of the DIERef struct.



================
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.h:47-48
+private:
+  unsigned m_section : 1;
+  dw_offset_t m_unit_offset;
+  dw_offset_t m_die_offset;
----------------
We we want this to be:
```
dw_offset_t m_section:1;
dw_offset_t m_unit_offset:31;
```

Otherwise we increase the size of the DIERef struct?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63400/new/

https://reviews.llvm.org/D63400





More information about the lldb-commits mailing list