[Lldb-commits] [PATCH] D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled

Mon Jun 17 00:11:01 PDT 2019

mgorny added a comment.

In D63380#1545428 <https://reviews.llvm.org/D63380#1545428>, @labath wrote:

> This definitely aren't all of our watchpoint tests. What's the reason for picking this particular bunch? Are they the only ones enabled on NetBSD right now?

Buildbot was down at the moment, so I went only for those that I was sure started failing once I fixed dbreg error reporting.

> Anyway, given that all of the watchpoint tests are already annotated with the "watchpoint" category, I think it would be better to handle this similar to how we handle other category-based skips (debug info flavours, c++ library types, etc.). This would also enable us to get rid of the "expectedFailure(windows)" decorator on all of these tests by implementing the skip centrally (though you don't have to do that right now). The category-based skipping happens around here: https://github.com/llvm-mirror/lldb/blob/master/packages/Python/lldbsuite/test/dotest.py#L1143

Will do that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63380/new/

https://reviews.llvm.org/D63380