[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

[António Afonso via Phabricator via lldb-commits]

aadsm updated this revision to Diff 204977.
aadsm added a comment.
Herald added a subscriber: emaste.

- Make ReadCStringFromMemory return llvm::Expected<llvm::StringRef>>
- Add documentation
- Address other comments
- Created `static const size_t g_cache_line_size` to avoid calling llvm::sys::Process::getPageSizeEstimate() all the time, that thing is expensive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62503/new/

https://reviews.llvm.org/D62503

Files:
  lldb/include/lldb/Host/common/NativeProcessProtocol.h
  lldb/source/Host/common/NativeProcessProtocol.cpp
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
  lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
  lldb/unittests/Host/NativeProcessProtocolTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62503.204977.patch
Type: text/x-patch
Size: 7330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190617/c7c5138c/attachment.bin>