[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

Roman Lebedev via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jun 15 11:53:26 PDT 2019

lebedev.ri added a comment.

In D63370#1544970 <https://reviews.llvm.org/D63370#1544970>, @siedentop wrote:

> In D63370#1544767 <https://reviews.llvm.org/D63370#1544767>, @lebedev.ri wrote:
> > The `llvm/utils/benchmark/` changes - can you please either submit them upstream yourself, or explicitly state that it is okay to **steal** them from you and submit?
> Thanks, @lebedev.ri, I was not aware that `llvm/utils/benchmark` contains Google Benchmark.
> I just checked: all three modified files in  `llvm/utils/benchmark/`  already have the same modifications on upstream (HEAD == 090faecb454fb).

Ah yes, apparently so, thanks for checking!
I have no further comments then.

> I propose that I remove my modifications from this review. I'll go ahead with this -- but please let me know if you disagree.



More information about the lldb-commits mailing list