[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

[Christoph Siedentop via Phabricator via lldb-commits]

siedentop created this revision.
siedentop added reviewers: zturner, beanz, xiaobai, kbobyrev.
Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, lebedev.ri, mgorny.
Herald added a reviewer: lebedev.ri.
Herald added projects: Sanitizers, LLDB, LLVM.

Specify message levels in CMake. Prefer STATUS (stdout).

      

As the default message mode (i.e. level) is NOTICE in CMake, more then necessary messages get printed to stderr. Some tools,  noticably ccmake treat this as an error and require additional confirmation and re-running CMake's configuration step.

      

This commit specifies a mode (either STATUS or WARNING or FATAL_ERROR)  instead of the default.

- I used `csearch -f 'llvm-project/.+(CMakeLists\.txt|cmake)' -l 'message\("'` to find all locations.
- Reviewers were chosen by the most common authors of specific files. If there are more suitable reviewers for these CMake changes, please let me know.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63370

Files:
  compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
  lldb/cmake/modules/LLDBConfig.cmake
  lldb/cmake/modules/LLDBStandalone.cmake
  llvm/cmake/modules/LLVMInstallSymlink.cmake
  llvm/utils/benchmark/CMakeLists.txt
  llvm/utils/benchmark/cmake/CXXFeatureCheck.cmake
  llvm/utils/benchmark/cmake/GetGitVersion.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63370.204883.patch
Type: text/x-patch
Size: 7676 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190615/73c0a742/attachment.bin>