[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes
Hui Huang via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 14 14:50:46 PDT 2019
Hui added inline comments.
Comment at: source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h:31
+ Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp,
+ const size_t data_size);
> Is this overriding something? Can you please use `override` to indicate that (throughout this patch)?
No, it doesn't override anything. It has different signature from the pure virtual method with the same name.
NativeRegisterContext::virtual Status ReadAllRegisterValues(lldb::DataBufferSP &data_sp) = 0;
It would be better to change the name to be ReadAllRegisterValuesWithSize or something else.
CHANGES SINCE LAST ACTION
More information about the lldb-commits