[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger
Hui Huang via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 12 15:16:36 PDT 2019
Hui added a comment.
In D63166#1539491 <https://reviews.llvm.org/D63166#1539491>, @labath wrote:
> Given that you're just moving code around, this should be fine, but I am including @amccarth, as I believe he is more familiar with this code.
> The thing I would consider in your place is whether putting this into a separate class is enough, or if you want to put it into a separate module/subfolder as well. The reason for that is that if this is in the same module as the liblldb stuff, then you will still end up pulling the all the transitive deps into lldb-server. If you put that into a separate module then you can control the dependencies more precisely. I don't think this is that important, since hopefully the local codepath (along with the deps) will disappear once lldb-server starts to work, but you know.. temporary solutions have a tendency for becoming permanent... Anyway, I'll leave the decision up to you..
I think ProcessWindows is based on Windows Basic Debugging Framework which can be leveraged by nativeprocess. So after the extraction of common codes into ProcessDebugger, they end up having same dependencies on DebuggerThread and ProcessDebugger in the same folder. (The native delegate is independent since the local delegate relies on a shareable process which native process is not).
CHANGES SINCE LAST ACTION
More information about the lldb-commits