[Lldb-commits] [PATCH] D63052: [Target] Remove Process::GetObjCLanguageRuntime

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 10 11:30:23 PDT 2019


xiaobai marked an inline comment as done.
xiaobai added inline comments.


================
Comment at: include/lldb/Target/ObjCLanguageRuntime.h:202
 
+  static ObjCLanguageRuntime *GetObjCLanguageRuntime(Process &process) {
+    return llvm::cast_or_null<ObjCLanguageRuntime>(
----------------
labath wrote:
> compnerd wrote:
> > I think it would be nice to just call this `Get` (and we could have equivalents in the other languages).  It makes the uses less verbose and repetitive.
> I like that idea.
I also like this idea. Would you mind if I did that in a follow up?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63052/new/

https://reviews.llvm.org/D63052





More information about the lldb-commits mailing list