[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet
António Afonso via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 10 10:36:51 PDT 2019
aadsm marked an inline comment as done.
aadsm added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2181
+template <typename T>
+Status NativeProcessLinux::ReadSVR4LibraryInfo(lldb::addr_t link_map_addr,
+ SVR4LibraryInfo &info,
> labath wrote:
> > This too could return an `llvm::Error`. `Expected<std::pair<SVR4LibraryInfo, addr_t>>` is a bit of a mouthful, but I'd consider that instead of by-ref returns too..
> What about that llvm::Error?
oops sorry, missed this one. I do my best to check if I addressed all the comments but sometimes I miss some :(.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits