[Lldb-commits] [lldb] r362406 - [lldb-server unittest] Add missing teardown logic

Antonio Afonso via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 3 08:18:15 PDT 2019


Author: aadsm
Date: Mon Jun  3 08:18:15 2019
New Revision: 362406

URL: http://llvm.org/viewvc/llvm-project?rev=362406&view=rev
Log:
[lldb-server unittest] Add missing teardown logic

Summary:
This test base class is missing the teardown making the second set of tests extending it to fail in an assertion in the FileSystem::Initialize() (as it's being initialized twice).
Not sure why this isn't failing the build bots.. (unless they're running without asserts?).

With this fix `ninja LLDBServerTests && ./tools/lldb/unittests/tools/lldb-server/tests/LLDBServerTests` successfully runs and passes all tests.

Reviewers: clayborg, xiaobai, labath

Reviewed By: xiaobai, labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D62788

Modified:
    lldb/trunk/unittests/tools/lldb-server/tests/TestBase.h

Modified: lldb/trunk/unittests/tools/lldb-server/tests/TestBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/tools/lldb-server/tests/TestBase.h?rev=362406&r1=362405&r2=362406&view=diff
==============================================================================
--- lldb/trunk/unittests/tools/lldb-server/tests/TestBase.h (original)
+++ lldb/trunk/unittests/tools/lldb-server/tests/TestBase.h Mon Jun  3 08:18:15 2019
@@ -25,6 +25,11 @@ public:
     lldb_private::HostInfo::Initialize();
   }
 
+  static void TearDownTestCase() {
+    lldb_private::HostInfo::Terminate();
+    lldb_private::FileSystem::Terminate();
+  }
+
   static std::string getInferiorPath(llvm::StringRef Name) {
     llvm::SmallString<64> Path(LLDB_TEST_INFERIOR_PATH);
     llvm::sys::path::append(Path, Name + LLDB_TEST_INFERIOR_SUFFIX);




More information about the lldb-commits mailing list