[Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 6 09:01:10 PDT 2019


mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.

I also hacked `-m32` for local testing. I generally agree this is a good thing to do but I don't really know how to reliably determine support for this. My main concern were C++ stdlib problems (which can be trivially worked around) but we also need to know whether the system has needed crt, libc… and kernel support for running 32-bit apps. Sounds like the only reliable way would be to crash-test this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62948/new/

https://reviews.llvm.org/D62948





More information about the lldb-commits mailing list