[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

Wed Jun 5 02:24:21 PDT 2019

sgraenitz marked 2 inline comments as done.
sgraenitz added inline comments.

================
Comment at: lldb/lit/CMakeLists.txt:7
+if(LLDB_BUILT_STANDALONE)
+  foreach(config_type ${CMAKE_CONFIGURATION_TYPES})
+    # In paths to our build-tree, replace CMAKE_CFG_INTDIR with our actual configuration names.
----------------
I will have to fix this. We only need one match here.

> Is there a way to share the logic between the two cmake files?

Unfortunately they're slightly different. lldb-dotest generates the actual driver scripts. Here, we only write the (one) cfg file and it relies on replacements of `%(build_mode)s` at runtime in ( see https://github.com/llvm/llvm-project/blob/6fc4c1cc54/lldb/lit/Suite/lit.site.cfg.in#L35).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62859/new/

https://reviews.llvm.org/D62859