[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 4 13:59:06 PDT 2019


stella.stamenova added inline comments.


================
Comment at: lldb/lit/CMakeLists.txt:13
+    # Replace the remaining CMAKE_CFG_INTDIR with ".", assuming the provided
+    # LLVM build-tree used a single-configuration generator like Ninja.
+    string(REPLACE ${CMAKE_CFG_INTDIR} "." LLDB_DOTEST_ARGS "${LLDB_DOTEST_ARGS}")
----------------
It looks like you need the update here also. Is there a way to share the logic between the two cmake files?

You probably no longer need the xcode pivot either, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62859/new/

https://reviews.llvm.org/D62859





More information about the lldb-commits mailing list