[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS
Stella Stamenova via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 4 09:54:59 PDT 2019
stella.stamenova requested changes to this revision.
stella.stamenova added a comment.
This revision now requires changes to proceed.
I don't think that this would apply very well to Visual Studio with the current change because it is likely that if you are using VS to build LLDB, you also used VS to build the dependencies. Even for xcode, I am sure that there are people who build the dependencies standalone with xcode and then are building LLDB standalone with xcode, so any change that absolutely treats the scenario as one or the other is going to break someone.
I think a better change would be to allow a parameter to be passed like your suggested `LLDB_PROVIDED_NINJA_BUILD_TREE=On` (except don't use Ninja in the name, how the tree came about is not important and it could also be make or a tree copied from another build) and then use that and LLDB_BUILT_STANDALONE for the pivot. Then if someone provides the new parameter, they know what they are doing and we can expect it to work for Xcode and VS both.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits