[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

[Alex Langford via Phabricator via lldb-commits]

xiaobai marked an inline comment as done.
xiaobai added inline comments.


================
Comment at: include/lldb/Target/ObjCLanguageRuntime.h:270-272
-  virtual lldb::addr_t LookupRuntimeSymbol(ConstString name) {
-    return LLDB_INVALID_ADDRESS;
-  }
----------------
clayborg wrote:
> xiaobai wrote:
> > clayborg wrote:
> > > Which language has this filled in? Only Swift?
> > Objective-C is the only thing that has this filled in at the moment, as I understand it.
> There must be a V1 or V2 implementation somewhere? From the looks of things here, it seems like we are pulling it out, but that must not be what is happening. So the V1 and V2 impls must have this already set as "lldb::addr_t LookupRuntimeSymbol(ConstString name) override;"?
Yes, AppleObjCRuntimeV2 has an override for this method. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62795/new/

https://reviews.llvm.org/D62795