[Lldb-commits] [PATCH] D62788: [lldb-server unittest] Add missing teardown logic

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I should add (since I'm guessing you found this problem while trying to add unit tests for your lldb-server changes) a bit of history about these tests. There are two kinds of tests for lldb-server. The python tests (test/testcases/tools/lldb-server) are older ones. The c++ ones were added in an attempt to fix the issues which made the python tests hard to understand. However, the person who was doing that left the project, so the were never quite finished. In fact, I've been lately considering just removing them and instead to try to fix the python issues incrementally in-place.

I don't think this has any immediate impact on what you're doing now -- feel free to use whichever method you find the easiest to write the tests you need. But if, after doing that, you have any feedback about one test method or the other, I'd very much like to hear it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62788/new/

https://reviews.llvm.org/D62788