[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

[Alex Langford via Phabricator via lldb-commits]

xiaobai marked an inline comment as done.
xiaobai added inline comments.


================
Comment at: source/Commands/CommandObjectMemory.cpp:479
+            if (persistent_vars->SetCompilerTypeFromPersistentDecl(
+                    lookup_type_name, clang_ast_type))
+              break;
----------------
compnerd wrote:
> Why is the parameter `clang_ast_type` and not based on `persistent_vars->getKind()`?
`clang_ast_type` is of type CompilerType. I was going to change the name in a follow up but I can do it in this change too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62797/new/

https://reviews.llvm.org/D62797