[Lldb-commits] [PATCH] D62416: Cleanup fixed form sizes.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Looks like a good change. Small comment inline but otherwise LGTM.



================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3170
                 uint32_t data_offset = attributes.DIEOffsetAtIndex(i);
-                uint32_t data_length =
-                    fixed_form_sizes.GetSize(form_value.Form());
-                if (data_length == 0) {
+                auto data_length = form_value.GetFixedSize();
+                if (data_length)
----------------
```
if (auto data_length = form_value.GetFixedSize()) 
    ...
```


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3188
                   uint32_t data_offset = attributes.DIEOffsetAtIndex(i);
-                  uint32_t data_length =
-                      fixed_form_sizes.GetSize(form_value.Form());
+                  auto data_length = form_value.GetFixedSize();
                   location.CopyOpcodeData(module, debug_info_data, data_offset,
----------------
Same as previous comment. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62416/new/

https://reviews.llvm.org/D62416