[Lldb-commits] [PATCH] D62089: Make ConnectionFileDescription work with all sockets

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 22 00:18:44 PDT 2019


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/unittests/Host/SocketTest.cpp:172-178
+  std::unique_ptr<TCPSocket> socket_a_up;
+  std::unique_ptr<TCPSocket> socket_b_up;
+  if (!IsAddressFamilySupported("127.0.0.1")) {
+    GTEST_LOG_(WARNING) << "Skipping test due to missing IPv4 support.";
+    return;
+  }
+  Socket *socket;
----------------
You have a bunch of unused variables here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62089/new/

https://reviews.llvm.org/D62089





More information about the lldb-commits mailing list