[Lldb-commits] [PATCH] D62216: [EditLine] Rewrite GetHistoryFilePath

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 21 15:04:30 PDT 2019


jingham added a comment.

I don't think that's quite right.  I think the behavior should be:

1. Try to make a .lldb directory a) If you can, then i) if wchar support ~/.lldb/.lldb-widehistory ii) else ~/.lldb/lldb-history b) else i) if wchar support ~/.lldb-widehistory ii) else ~/.lldb-history

Unless I'm reading it wrong, your patch bails in case b.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62216/new/

https://reviews.llvm.org/D62216





More information about the lldb-commits mailing list