[Lldb-commits] [PATCH] D61847: [lldb] modernize codebase with modernize-use-nullptr

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 13 02:35:39 PDT 2019


teemperor added inline comments.


================
Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:76
 static constexpr PropertyDefinition g_properties[] = {
-    {"load-kexts", OptionValue::eTypeBoolean, true, true, NULL, {},
+    {"load-kexts",
+     OptionValue::eTypeBoolean,
----------------
kwk wrote:
> teemperor wrote:
> > Can you revert the auto-formatting here?
> @teemperor I sure could or if you want I can sourround this section with ` // clang-format off` and ` // clang-format on` to prevent it from being ever formatted again. 
I wouldn't do it in this patch, but in general that sounds like a good idea to add this to all the g_properties sections. I'll probably replace most of these sections with some tablegen soon(TM), so be aware that that work might only be short-lived :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61847/new/

https://reviews.llvm.org/D61847





More information about the lldb-commits mailing list