[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

Fri May 17 00:53:24 PDT 2019

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I think this looks better than the original. Given that the only callers of `SourceInitFile` pass a constant value for the `InitFileLocation` argument, what I'd consider also doing is getting rid of the function and the enum, and making SourceInitFileHome/SourceInitFileCwd the main entry points.

One day I'm going to start a thread about reducing the use of FileSpecs in the FileSystem api...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61994/new/

https://reviews.llvm.org/D61994