[Lldb-commits] [PATCH] D62011: Remove `SymbolFileDWARF *` when there is already `DWARFUnit *`

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil created this revision.
jankratochvil added reviewers: clayborg, labath, JDevlieghere.
jankratochvil added a project: LLDB.
Herald added subscribers: jdoerfert, aprantl.

In D61502#1503247 <https://reviews.llvm.org/D61502#1503247> @clayborg suggested that `SymbolFileDWARF *dwarf2Data` is really redundant in all the calls with also having `DWARFUnit *cu`.  So remove it.  I see no regressions.

There are some nullptr checks, I changed those needed from `dwarf2Data == nullptr` to `cu == nullptr` but then who knows if they can happen.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D62011

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFBaseDIE.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h
  lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
  lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
  lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62011.199828.patch
Type: text/x-patch
Size: 51622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190516/1df1226e/attachment-0001.bin>