[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I wouldn't want to over-proliferate these, but in general I think this is a good idea. What I would find particularly useful is if we checked in the configurations used by all the bots in here, as that would make it easier to figure out what's going on if one of them breaks and the reason is not obvious...



================
Comment at: lldb/cmake/caches/Apple-lldb-osx.cmake:4
+set(CMAKE_OSX_DEPLOYMENT_TARGET 10.11 CACHE STRING "")
+set(CMAKE_INSTALL_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/install/usr" CACHE STRING "")
+
----------------
Are you sure including `{CMAKE_CURRENT_BINARY_DIR}` here is a good idea? I think llvm tries to avoid that generally, but my experience from other projects tells me that the value of install prefix tends to end up embedded in the final binaries in various ways.

I believe the expected usage of this variable is to make it point to the final resting place of the executables, which in your case would be `/System` or whatever. Then, if you want to copy the to-be-installed files into a staging area first, you're expected to do that with "DESTDIR=whatever ninja install".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61956/new/

https://reviews.llvm.org/D61956