[Lldb-commits] [PATCH] D61833: Fix IPv6 support on lldb-server platform

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 13 23:51:53 PDT 2019


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks fine to me. Thank you for fixing this.



================
Comment at: lldb/unittests/Host/SocketTestUtilities.cpp:16
+namespace {
+void AcceptThread(Socket *listen_socket, bool child_processes_inherit,
+                  Socket **accept_socket, Status *error) {
----------------
LLVM prefers static functions over ones in anonymous namespaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61833/new/

https://reviews.llvm.org/D61833





More information about the lldb-commits mailing list